remove doc generation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I understand these were not adding a lot of value as is, I do think some sort of SDK API reference is important to have and we should revisit that in the future maybe. I don't think that just having the official Eppo docs is enough. As an example, here are Stripe's JS SDK API reference: https://docs.stripe.com/terminal/references/api/js-sdk#stripeterminal-create |
greghuels
added a commit
that referenced
this pull request
Jul 11, 2024
This reverts commit b8ceea1.
greghuels
added a commit
that referenced
this pull request
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
These generated docs seem pretty low value, they just explain the types which should be self-evident, and are just causing our PRs to be larger in size then they need to be.
Description
docsdirectoryHow has this been tested?